api: move types/versions to client/pkg and daemon/internal#51284
Merged
vvoland merged 1 commit intomoby:masterfrom Oct 24, 2025
Merged
api: move types/versions to client/pkg and daemon/internal#51284vvoland merged 1 commit intomoby:masterfrom
vvoland merged 1 commit intomoby:masterfrom
Conversation
This change moves the api/types/versions package out into client and daemon versions. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
There was a problem hiding this comment.
Pull Request Overview
This PR moves the api/types/versions package to separate locations for client and daemon code, addressing issue #51086. The package is relocated to client/pkg/versions for client-side code and daemon/internal/versions for daemon-side code.
Key changes:
- Updated import paths across integration tests to use
client/pkg/versions - Updated import paths across daemon server components to use
daemon/internal/versions - Added test file for version comparison functionality in the daemon package
Reviewed Changes
Copilot reviewed 27 out of 36 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| integration/volume/mount_test.go | Updated import from api/types/versions to client/pkg/versions |
| integration/network/network_linux_test.go | Updated import from api/types/versions to client/pkg/versions |
| integration/container/mounts_linux_test.go | Updated import from api/types/versions to client/pkg/versions |
| integration/container/list_test.go | Updated import from api/types/versions to client/pkg/versions |
| integration/container/create_test.go | Updated import from api/types/versions to client/pkg/versions |
| integration-cli/docker_cli_swarm_test.go | Updated import from api/types/versions to client/pkg/versions |
| integration-cli/docker_cli_push_test.go | Updated import from api/types/versions to client/pkg/versions |
| integration-cli/docker_cli_build_test.go | Updated import from api/types/versions to client/pkg/versions |
| daemon/server/server.go | Updated import from api/types/versions to daemon/internal/versions |
| daemon/server/router/volume/volume_routes.go | Updated import from api/types/versions to daemon/internal/versions |
| daemon/server/router/system/system_routes.go | Updated import from api/types/versions to daemon/internal/versions |
| daemon/server/router/swarm/helpers.go | Updated import from api/types/versions to daemon/internal/versions |
| daemon/server/router/swarm/cluster_routes.go | Updated import from api/types/versions to daemon/internal/versions |
| daemon/server/router/network/network_routes.go | Updated import from api/types/versions to daemon/internal/versions |
| daemon/server/router/local.go | Updated import from api/types/versions to daemon/internal/versions |
| daemon/server/router/image/image_routes.go | Updated import from api/types/versions to daemon/internal/versions |
| daemon/server/router/container/inspect.go | Updated import from api/types/versions to daemon/internal/versions |
| daemon/server/router/container/exec.go | Updated import from api/types/versions to daemon/internal/versions |
| daemon/server/router/container/container_routes.go | Updated import from api/types/versions to daemon/internal/versions |
| daemon/server/router/build/build_routes.go | Updated import from api/types/versions to daemon/internal/versions |
| daemon/server/middleware/version.go | Updated import from api/types/versions to daemon/internal/versions |
| daemon/internal/versions/compare_test.go | Added test coverage for version comparison functionality |
| daemon/config/config.go | Updated import from api/types/versions to daemon/internal/versions |
| client/image_list.go | Updated import from api/types/versions to client/pkg/versions |
| client/errors.go | Updated import from api/types/versions to client/pkg/versions |
| client/client.go | Updated import from api/types/versions to client/pkg/versions |
| client/build_prune.go | Updated import from api/types/versions to client/pkg/versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dmcgowan
approved these changes
Oct 24, 2025
vvoland
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Addresses #51086
This change moves the api/types/versions package out into client and daemon versions.
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)