client/distribution_inspect: Wrap options and result#51264
Merged
thaJeztah merged 1 commit intomoby:masterfrom Oct 22, 2025
Merged
client/distribution_inspect: Wrap options and result#51264thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
austinvazquez
approved these changes
Oct 22, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the DistributionInspect API to use structured options and result types instead of individual parameters, improving API consistency and extensibility.
Key Changes:
- Introduced
DistributionInspectOptionsstruct to wrap theencodedRegistryAuthparameter - Introduced
DistributionInspectResultstruct to wrap the return value - Updated all call sites to use the new API signature
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| client/distribution_inspect.go | Added new options and result structs; updated function signature and implementation to use these types |
| client/client_interfaces.go | Updated interface definition to match new function signature |
| client/service_create.go | Updated function call to pass options struct instead of individual auth parameter |
| client/distribution_inspect_test.go | Updated test to pass empty options struct instead of empty string |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.