api/types: move Ping and swarm.Status to client#51258
Merged
thaJeztah merged 1 commit intomoby:masterfrom Oct 22, 2025
Merged
Conversation
thaJeztah
commented
Oct 22, 2025
| // back to the oldest API version supported. | ||
| func (cli *Client) NegotiateAPIVersionPing(pingResponse types.Ping) { | ||
| func (cli *Client) NegotiateAPIVersionPing(pingResponse PingResult) { | ||
| // TODO(thaJeztah): should this take a "Ping" option? It only consumes the version. This method should be removed overall and not be exported. |
Member
Author
There was a problem hiding this comment.
I have some ideas to get rid of this, but will work on that for a follow-up;
- Make
Pingalso perform negotiation if the CLI is configured to do so - Optionally, add a
PingOptionsstruct to force negotiation
With that, we could potentially;
- Remove
NegotiateAPIVersionPing - Remove
NegotiateAPIVersion(which would now becomePing()with theNegotiateAPIVersionoption enabled
thaJeztah
commented
Oct 22, 2025
client/ping.go
Outdated
Comment on lines
+21
to
+47
| func (cli *Client) Ping(ctx context.Context) (types.Ping, error) { | ||
| func (cli *Client) Ping(ctx context.Context) (PingResult, error) { |
Member
Author
There was a problem hiding this comment.
Actually; let me already add a PingOptions struct
94bc8e1 to
7fe8274
Compare
The API does not produce these as a response; the fields in the Ping struct, including the Swarm status are propagated from headers returned by the /_ping endpoint. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
7fe8274 to
8dc5d1e
Compare
Merged
vvoland
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiskUsage.*fields and add type specific fields #51235 (comment)The API does not produce these as a response; the fields in the Ping struct, including the Swarm status are propagated from headers returned by the /_ping endpoint.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)