client: refactor service api client functions for defined options/res…#51252
Merged
austinvazquez merged 1 commit intomoby:masterfrom Oct 22, 2025
Merged
Conversation
thaJeztah
approved these changes
Oct 21, 2025
Comment on lines
+72
to
+80
| func newTaskLogsResult(rc io.ReadCloser) TaskLogsResult { | ||
| if rc == nil { | ||
| panic("nil io.ReadCloser") | ||
| } | ||
| return TaskLogsResult{ | ||
| rc: rc, | ||
| close: sync.OnceValue(rc.Close), | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
OK for a follow-up; I highly suspect we may have existing utilities for this; possibly we could either reuse those or make something "generic".
Contributor
Author
There was a problem hiding this comment.
lol I wrote a generic logResults type but then thought perhaps I was overcooking. 🤣
Member
There was a problem hiding this comment.
Yeah; we should look what's best we can do that later!
Member
|
@austinvazquez looks like something broke somewhere |
Contributor
Author
|
Yeah going through the delta now to see what I missed. |
a4aa4c1 to
0d46e66
Compare
Contributor
Author
|
I believe I found the issue in a test cleanup. An inspect was being deferred instead of a remove service call causing conflicts with other tests. |
Member
|
🙈 needs a rebase (sorry!) |
…ult structs Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
0d46e66 to
cd08b79
Compare
10 tasks
This was referenced Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ult structs
- What I did
Part of #50965
This change refactors the client
ServiceAPIClientinterface implementations to use client module defined option structs and results to simplify future development of the client.Non-functional touchups from #51244
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)