Skip to content

integration-cli: migrate test api error json#51176

Closed
sameergupta4873 wants to merge 1 commit intomoby:masterfrom
sameergupta4873:50159-migrate-test-api-error-json
Closed

integration-cli: migrate test api error json#51176
sameergupta4873 wants to merge 1 commit intomoby:masterfrom
sameergupta4873:50159-migrate-test-api-error-json

Conversation

@sameergupta4873
Copy link
Contributor

@sameergupta4873 sameergupta4873 commented Oct 13, 2025

  • What I did

Migrated the TestAPIErrorJSON to integration tests in reference to the integration-cli migration epic #50159

  • How I did it

Using test on integration-cli/docker_api_test.go

  • How to verify it

Run the integration test

@sameergupta4873 sameergupta4873 changed the title test: migrate test api error json integration-cli: migrate test api error json Oct 13, 2025
@sameergupta4873 sameergupta4873 force-pushed the 50159-migrate-test-api-error-json branch from ec233fa to a8a86a9 Compare October 13, 2025 20:48
@sameergupta4873
Copy link
Contributor Author

sameergupta4873 commented Oct 14, 2025

Hi @vvoland, please review the changes. Thanks

robmry
robmry reviewed Oct 14, 2025
View reviewed changes
Copy link
Contributor

@robmry robmry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sameergupta4873 - thank you for taking a look at this.

It needs a couple of updates (please squash changes into a single commit) ... and I think it'd be better to name the file api_test.go, to make a landing place for the other tests in integration-cli/docker_api_test.go.

@sameergupta4873 sameergupta4873 force-pushed the 50159-migrate-test-api-error-json branch from a8a86a9 to 175ec5f Compare October 14, 2025 21:17
@sameergupta4873 sameergupta4873 force-pushed the 50159-migrate-test-api-error-json branch 2 times, most recently from b7ccaef to f0ffc3a Compare October 14, 2025 21:34
@sameergupta4873
Copy link
Contributor Author

sameergupta4873 commented Oct 14, 2025 •
edited
Loading

Thank you for the review, @robmry.

I’ve incorporated the suggested changes:

  • Renamed the test file to api_test.go.
  • Updated the test setup to use setupTest(t).
  • Moved the getErrorMessage helper function to integration/system/utils_test.go.

Verified locally using:

TEST_FILTER='TestAPIErrorJSON' make test-integration

and the test passed successfully.

Please let me know if any further refinements are needed. Thank you again for your guidance.

@robmry
Copy link
Contributor

robmry commented Oct 16, 2025

Thank you for the update - looks good, but a merge commit has crept in somehow ... could you drop that one? (Maybe need to rebase your branch instead of merging to it?)

@sameergupta4873
test: migrate test api error json
1c2dc57 
Signed-off-by: Sameer Gupta <sameergupta4873@gmail.com>

test: migrate test api error json
@sameergupta4873 sameergupta4873 force-pushed the 50159-migrate-test-api-error-json branch from 5d38bd9 to 1c2dc57 Compare October 18, 2025 16:26
@sameergupta4873
Copy link
Contributor Author

sameergupta4873 commented Oct 18, 2025

Thanks, @robmry!
I’ve rebased the branch on top of the latest master to remove the merge commit — the history should now be clean.

Please let me know if everything looks good or if you spot anything else that needs adjusting.

@robmry robmry mentioned this pull request Oct 20, 2025
Merged
This was referenced Oct 20, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianon tianon Awaiting requested review from tianon

@robmry robmry Awaiting requested review from robmry

Assignees

No one assigned

Labels

area/builder/buildkit Build area/ci area/daemon Core Engine area/dependencies area/networking Networking area/testing module/client platform/windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sameergupta4873 @robmry