api/templates: align with go-swagger v1.32.3#51168
Merged
thaJeztah merged 1 commit intomoby:masterfrom Oct 11, 2025
Merged
Conversation
Align our custom templates with the one from upstream; https://github.com/go-swagger/go-swagger/tree/v0.32.3/generator/templates - Add "TODO" comments in places where we applied patches to make it easier to compare with upstream, and to see where differences are intentional. - Update the server/operations.gotmpl template; - Add the "generated" header in the right place, so that it's recognized as generated file. - Add back the upstream template code; instead of removing the code, put a "if false" block around it; this allows comparing our forked templates with upstream when updating the version of go-swagger (to make sure we're not missing fixes). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was referenced Oct 11, 2025
Merged
thaJeztah
commented
Oct 11, 2025
Comment on lines
+1
to
+6
| // Code generated by go-swagger; DO NOT EDIT. | ||
|
|
||
| package image | ||
|
|
||
| // ---------------------------------------------------------------------------- | ||
| // Code generated by `swagger generate operation`. DO NOT EDIT. | ||
| // Code generated by `swagger generate operation`. |
Member
Author
There was a problem hiding this comment.
This properly adds the "generated" header
robmry
approved these changes
Oct 11, 2025
Member
Author
|
Thanks Rob! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
api/templates: align with go-swagger v1.32.3
Align our custom templates with the one from upstream; https://github.com/go-swagger/go-swagger/tree/v0.32.3/generator/templates
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)