client: ImagePullResponse: use sync.OnceValue#51160
Merged
thaJeztah merged 1 commit intomoby:masterfrom Oct 10, 2025
Merged
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
vvoland
reviewed
Oct 10, 2025
| } | ||
| }) | ||
| return err | ||
| return r.close() |
Contributor
There was a problem hiding this comment.
This slightly changes the behavior - previously the error would only be returned on the first Close call. Now each Close call will still return the same error as the first run.
Probably not a big issue in this case... but worth pointing out just in case
Member
Author
There was a problem hiding this comment.
Oh! Good call; I was thinking "we capture the err" but of course that err var is created on every invocation.
I guess keeping the err var is actually more "correct", or, well, it would return the same result every time it's called
vvoland
approved these changes
Oct 10, 2025
Member
Author
|
I'll bring this one in once CI completes; the thing I was considering with this change;
|
Member
Author
|
Failure is unrelated; flaky test; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)