client/pkg/jsonmessage: refactor in terms of api/types/jsonstream#51156
Merged
vvoland merged 1 commit intomoby:masterfrom Oct 30, 2025
Merged
client/pkg/jsonmessage: refactor in terms of api/types/jsonstream#51156vvoland merged 1 commit intomoby:masterfrom
api/types/jsonstream#51156vvoland merged 1 commit intomoby:masterfrom
Conversation
c53d765 to
131a8da
Compare
Contributor
Author
|
cc @ndeloof |
thaJeztah
reviewed
Oct 11, 2025
Comment on lines
+4
to
+8
|
|
||
| // JSONMessage defines a message struct. It describes | ||
| // the created time, where it from, status, ID of the | ||
| // message. It's used for docker events. | ||
| type Message struct { |
Member
There was a problem hiding this comment.
Need to look at this, because I think events is the only stream ... not actually using this; we have an events.Message type now, which .. .does have some fields that overlap;
moby/api/types/events/events.go
Lines 111 to 121 in f5fec92
I think this may have been when things changed; d6bd79c
Signed-off-by: Cory Snider <csnider@mirantis.com>
131a8da to
bbaeb90
Compare
thaJeztah
approved these changes
Oct 30, 2025
vvoland
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/streamformatter,pkg/progresstodaemon/internal#51153jsonstream,jsonmessage,progresscleanup #50575- What I did
Refactored client/pkg/jsonmessage to reference the API types, eliminating its separate definition.
- How I did it
By changing some methods and struct fields to functions and function arguments.
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)