Skip to content

api: fix swarm network field from addr to prefix#51150

Merged
austinvazquez merged 1 commit intomoby:masterfrom
austinvazquez:fix-swarm-type
Oct 9, 2025
Merged

api: fix swarm network field from addr to prefix#51150
austinvazquez merged 1 commit intomoby:masterfrom
austinvazquez:fix-swarm-type

Conversation

@austinvazquez
Copy link
Contributor

@austinvazquez austinvazquez commented Oct 9, 2025

- What I did

The swarm network endpoint virtual IP Addr and network attach Addresses fields previously accepted CIDR notation. While ipnet.Addr makes more sense here, we are hamstrung by backwards compatibility with older clients if we stop accepting wires with /xx

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
@austinvazquez austinvazquez self-assigned this Oct 9, 2025
@austinvazquez austinvazquez changed the title api: fix swarm network field from addr to prefix [WIP] api: fix swarm network field from addr to prefix Oct 9, 2025
@austinvazquez austinvazquez added area/api API area/swarm kind/bugfix PR's that fix bugs release-blocker PRs we want to block a release on labels Oct 9, 2025
Copy link
Contributor

@corhere corhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@austinvazquez austinvazquez changed the title [WIP] api: fix swarm network field from addr to prefix api: fix swarm network field from addr to prefix Oct 9, 2025
@austinvazquez austinvazquez marked this pull request as ready for review October 9, 2025 18:30
@robmry robmry added this to the 29.0.0 milestone Oct 9, 2025
@austinvazquez austinvazquez merged commit 6e46844 into moby:master Oct 9, 2025
235 of 236 checks passed
@austinvazquez austinvazquez deleted the fix-swarm-type branch October 9, 2025 19:15
@thompson-shaun thompson-shaun moved this from New to Complete in 🔦 Maintainer spotlight Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api API area/swarm kind/bugfix PR's that fix bugs module/api release-blocker PRs we want to block a release on

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants