api/types/system: remove deprecated Commit.Expected field#51127
Merged
akerouanton merged 1 commit intomoby:masterfrom Oct 8, 2025
Merged
api/types/system: remove deprecated Commit.Expected field#51127akerouanton merged 1 commit intomoby:masterfrom
akerouanton merged 1 commit intomoby:masterfrom
Conversation
This field was deprecated API v1.48 in [moby/moby@ff191c5], and removed in API v1.49 in [moby/moby@564abf9]. This patch: - Removes the field from the API Go types. - Reimplements the `/info` endpoint with the `compat` package to replace the local `infoResponse` implementation. - Removes the `ServiceConfig.ExtraFields` field in api/types/registry introduced in [moby/moby@7d9c50d] to backfill the `AllowNondistributableArtifactsCIDRs` and `AllowNondistributableArtifactsHostnames` fields for API < v1.47. We should also consider deprecating the `ContainerdCommit`, `RuncCommit` and `InitCommit` fields on the `/info` response (as we also include this information as part of the components returned in `/version`), but those can still be useful currently for situations where a user only provides `docker info` output. [moby/moby@ff191c5]: moby@ff191c5 [moby/moby@564abf9]: moby@564abf9 [moby/moby@7d9c50d]: moby@7d9c50d Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
robmry
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
api/types/system: remove deprecated Commit.Expected field
This field was deprecated API v1.48 in moby@ff191c5, and removed in API v1.49 in moby@564abf9.
This patch:
/infoendpoint with thecompatpackage to replace the localinfoResponseimplementation.ServiceConfig.ExtraFieldsfield in api/types/registry introduced in moby@7d9c50d to backfill theAllowNondistributableArtifactsCIDRsandAllowNondistributableArtifactsHostnamesfields for API < v1.47.We should also consider deprecating the
ContainerdCommit,RuncCommitandInitCommitfields on the/inforesponse (as we also include this information as part of the components returned in/version), but those can still be useful currently for situations where a user only providesdocker infooutput.- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)