Skip to content

api/types/plugin: deprecate Config.DockerVersion field#51109

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:deprecate_plugin_dockerversion
Oct 6, 2025
Merged

api/types/plugin: deprecate Config.DockerVersion field#51109
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:deprecate_plugin_dockerversion

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Oct 6, 2025

- Human readable description for the release notes

api/types/plugin: deprecate `Config.DockerVersion` field.

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 29.0.0 milestone Oct 6, 2025
@thaJeztah thaJeztah force-pushed the deprecate_plugin_dockerversion branch 2 times, most recently from c91751d to 07cd37a Compare October 6, 2025 10:30
@thaJeztah thaJeztah mentioned this pull request Oct 6, 2025
Merged
robmry
robmry approved these changes Oct 6, 2025
View reviewed changes
@thaJeztah
api/types/plugin: deprecate Config.DockerVersion field
c4fda95 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the deprecate_plugin_dockerversion branch from 07cd37a to c4fda95 Compare October 6, 2025 12:20
@thaJeztah
Copy link
Member Author

thaJeztah commented Oct 6, 2025 •
edited
Loading

Windows looks to be a flaky test;

=== Failed
=== FAIL: integration/build TestBuildWithRemoveAndForceRemove/successful_build_with_no_removal (2.86s)
    build_test.go:120: assertion failed: 2 (tc.numberOfIntermediateContainers int) != 1 (int): Expected 2 remaining intermediate containers, got 1

=== FAIL: integration/build TestBuildWithRemoveAndForceRemove (3.87s)

Created a tracking ticket:

@thaJeztah
Copy link
Member Author

thaJeztah commented Oct 6, 2025

OK, that's the only failure; bringing this one in

@thaJeztah thaJeztah merged commit 694e30a into moby:master Oct 6, 2025
257 of 259 checks passed
@thaJeztah thaJeztah deleted the deprecate_plugin_dockerversion branch October 6, 2025 14:35
@thaJeztah thaJeztah mentioned this pull request Oct 7, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@austinvazquez austinvazquez austinvazquez approved these changes

@robmry robmry robmry approved these changes

Assignees

No one assigned

Labels

area/api API area/go-sdk area/plugins impact/changelog impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/refactor PR's that refactor, or clean-up code module/api process/cherry-pick/28.x status/4-merge

Projects

None yet

Milestone

29.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah @austinvazquez @robmry