api/types/image: InspectResponse: deprecate Parent, DockerVersion#51104
Merged
thaJeztah merged 1 commit intomoby:masterfrom Oct 6, 2025
Merged
api/types/image: InspectResponse: deprecate Parent, DockerVersion#51104thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
9bb564c to
b47c611
Compare
thaJeztah
commented
Oct 5, 2025
| // This field is omitted if not set. | ||
| // | ||
| // Deprecated: this field is deprecated, and will be removed in the next release. | ||
| Author string `json:",omitempty"` |
Member
Author
There was a problem hiding this comment.
Moved back to draft for now; perhaps depreciating Author is a bit too aggressive, as there's an equivalent in the OCI as well; https://github.com/opencontainers/image-spec/blob/6519a62d628ec31b5da156de745b516d8850c8e3/specs-go/v1/config.go#L98
Member
Author
There was a problem hiding this comment.
OK; reverted this part; not deprecating Author for now (but we can do in a follow-up)
The image inspect response has various fields that were deprecated as part of the legacy builder, or Dockerfile syntax; - The `Parent` field is only used for the legacy builder, and only set for images that are built locally (i.e., not persisted when pulling an image). - The `DockerVersion` field is only set when building images with the legacy builder, and empty in most cases. This patch deprecates the fields in the `InspectResponse` go struct, as these fields will no longer be set in future once the legacy builder is removed (`Parent`, `DockerVersion`). The legacy builder's deprecation in [cli@4d8e457] / [cli@fd22746] (docker 23.0, API v1.42), however the related API fields were kept so that information of legacy images would not be discarded. The API continues to return these fields if set, allowing the client to print the fields for informational purposes when printing the raw response, but these fields should be considered "transitional", and not be depended on; deprecating the fields helps raise awareness. [cli@4d8e457]: docker/cli@4d8e457 [cli@fd22746]: docker/cli@fd22746 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
b47c611 to
bd8a99b
Compare
vvoland
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
api/types/image: InspectResponse: deprecate
Parent,DockerVersionThe image inspect response has various fields that were deprecated as
part of the legacy builder, or Dockerfile syntax;
Parentfield is only used for the legacy builder, and only set forimages that are built locally (i.e., not persisted when pulling an image).
DockerVersionfield is only set when building images with the legacybuilder, and empty in most cases.
This patch deprecates the fields in the
InspectResponsego struct, asthese fields will no longer be set in future once the legacy builder is
removed (
Parent,DockerVersion). The legacy builder's deprecation incli@4d8e457 / cli@fd22746 (docker 23.0, API v1.42), however the related
API fields were kept so that information of legacy images would not be
discarded.
The API continues to return these fields if set, allowing the client to
print the fields for informational purposes when printing the raw response,
but these fields should be considered "transitional", and not be depended
on; deprecating the fields helps raise awareness.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)