daemon/server: move GetImageOpts, ImageInspectOpts to imagebackend#51102
Merged
thaJeztah merged 1 commit intomoby:masterfrom Oct 6, 2025
Merged
daemon/server: move GetImageOpts, ImageInspectOpts to imagebackend#51102thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Oct 5, 2025
Comment on lines
152
to
154
| // CreateImageConfig is the configuration for creating an image from a | ||
| // container. | ||
| type CreateImageConfig struct { |
Member
Author
There was a problem hiding this comment.
There's a couple more that need some untangling; this one is used to "create an image from a container" (i.e., docker commit), but there's also a CommitConfig below. Some of those are currently needed because container.Config is used in places where ... likely ocispec.Config or dockerspec.Config should be used (as those are the only fields persisted in the image .
4 tasks
robmry
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)