Skip to content

use consistent alias for docker image spec#51099

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:consistent_alias
Oct 6, 2025
Merged

use consistent alias for docker image spec#51099
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:consistent_alias

Conversation

@thaJeztah
Copy link
Member

This package was aliased as "imagespec" in some places, and "dockerspec" in other places, which made it easy to confuse.

Change all uses of this package to be aliased as "dockerspec" and configure an "importas" linting check to enforce it.

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 29.0.0 milestone Oct 5, 2025
@thaJeztah thaJeztah added status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Oct 5, 2025
@thaJeztah
Copy link
Member Author

Flaky test; #51079

=== Failed
=== FAIL: daemon/logger/fluentd TestReadWriteTimeoutsAreEffective (10.01s)
    fluentd_test.go:315: Test timed out, which is unexpected
--- PASS: TestReadWriteTimeoutsAreEffective/write_timeout (0.00s)
--- PASS: TestReadWriteTimeoutsAreEffective/read_timeout (10.01s)

This package was aliased as "imagespec" in some places, and "dockerspec"
in other places, which made it easy to confuse.

Change all uses of this package to be aliased as "dockerspec" and configure
an "importas" linting check to enforce it.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah merged commit 3c4bd36 into moby:master Oct 6, 2025
61 of 62 checks passed
@thaJeztah thaJeztah deleted the consistent_alias branch October 6, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants