Deprecate and remove kernel memory tcp#51066
Merged
thaJeztah merged 2 commits intomoby:masterfrom Sep 30, 2025
Merged
Conversation
c57dda4 to
56b8226
Compare
dmcgowan
approved these changes
Sep 29, 2025
thaJeztah
approved these changes
Sep 30, 2025
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
I'll do a quick push of the markdown, just in case docs.docker.com doesn't like it.
api/docs/CHANGELOG.md
Outdated
Comment on lines
+53
to
+56
| * Deprecated: The field `KernelMemoryTCP` as part of `POST /containers/{id}/update` and | ||
| returned by `GET /containers/{id}/json` is deprecated and will be removed in the next API version. | ||
| * Deprecated: The field `KernelMemoryTCP` as part of `GET /info` is deprecated and will be removed | ||
| in the next API version. |
Member
There was a problem hiding this comment.
indentation looks off here; looks like GitHub renders it OK, but I may do a quick push, just in case docs.docker.com isn't able to render it correctly.
api/types/system/info.go
Outdated
| Images int | ||
| Driver string | ||
| DriverStatus [][2]string | ||
| SystemStatus [][2]string `json:",omitempty"` // SystemStatus is only propagated by the Swarm standalone API |
Member
There was a problem hiding this comment.
Forgot we still had this one; this field was never set by the docker daemon, but was something that was augmented by the swarm v1 API, which. It's possible that Mirantis is still using this, but not sure if they need this to be in the API types from this repository, or if they use their own types to (un)marshal the response.
cc @corhere
Starting with kernel v6.12, kernel memory TCP accounting is deprecated for cgroups v1. Note: kernel memory TCP accounting is not supported by cgroups v2. See torvalds/linux@d046ff4 Signed-off-by: Austin Vazquez <austin.vazquez@docker.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
56b8226 to
a7edbe8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Kernel v6.12 has deprecated
memory.kmem.tcp.limit_in_bytesalong with all other kernel memory TCP accounting for cgroups v1. [1]This change deprecates and removes support for
KernelMemoryTCPfrom the API module.[1] torvalds/linux@d046ff4
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)