client, integration-cli: adjust for go1.25, TLS1.3 handshake#51055
Merged
thaJeztah merged 2 commits intomoby:masterfrom Sep 29, 2025
Merged
client, integration-cli: adjust for go1.25, TLS1.3 handshake#51055thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah merged 2 commits intomoby:masterfrom
Conversation
AkihiroSuda
approved these changes
Sep 27, 2025
thaJeztah
commented
Sep 29, 2025
Go 1.25 / TLS 1.3 may produce a generic "handshake failure" whereas TLS 1.2 may produce a "bad certificate" TLS alert. See golang/go#56371 > https://tip.golang.org/doc/go1.12#tls_1_3 > > In TLS 1.3 the client is the last one to speak in the handshake, so if > it causes an error to occur on the server, it will be returned on the > client by the first Read, not by Handshake. For example, that will be > the case if the server rejects the client certificate. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
aeb0a5b to
f85ab20
Compare
Go 1.25 / TLS 1.3 may produce a generic "handshake failure" whereas TLS 1.2 may produce a "bad certificate" TLS alert. See golang/go#56371 > https://tip.golang.org/doc/go1.12#tls_1_3 > > In TLS 1.3 the client is the last one to speak in the handshake, so if > it causes an error to occur on the server, it will be returned on the > client by the first Read, not by Handshake. For example, that will be > the case if the server rejects the client certificate. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
f85ab20 to
3241d46
Compare
austinvazquez
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
integration-cli: adjust TestHTTPSInfoRogueCert for TLS1.3 handshake
Go 1.25 / TLS 1.3 may produce a generic "handshake failure"
whereas TLS 1.2 may produce a "bad certificate" TLS alert.
See golang/go#56371
client: Client.doRequest: adjust error matching for TLS1.3 handshake
Go 1.25 / TLS 1.3 may produce a generic "handshake failure" whereas
TLS 1.2 may produce a "bad certificate" TLS alert.
See golang/go#56371