ipams: Re-enable legacy remote plugins support#51009
Merged
robmry merged 1 commit intomoby:masterfrom Sep 19, 2025
Merged
Conversation
akerouanton
reviewed
Sep 19, 2025
| if err := remoteIpam.Register(r, pg); err != nil { | ||
| return err | ||
| } | ||
| if err := remoteIpam.Register(r, pg); err != nil { |
Member
There was a problem hiding this comment.
If I get it correctly, pg is nil on Windows because it doesn't support 'managed' plugins, right? Would you mind adding a comment telling that, so we don't reintroduce this issue?
Contributor
Author
There was a problem hiding this comment.
@akerouanton Yes, managed plugins are not implemented for Windows at the moment. Comment added.
Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>
2f5df20 to
aa49231
Compare
akerouanton
approved these changes
Sep 19, 2025
robmry
approved these changes
Sep 19, 2025
Contributor
|
This one flaked again, but it's unrelated ... |
Contributor
|
@robmry @akerouanton @olljanat should this one have a changelog entry? |
Member
|
Oh! I should mention that I marked this for backporting because it was a regression (at least, from what I understood from the conversation above) and it looked like a small enough change to include. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
3c97181 which was part of big refactoring PR #47727 disabled remote IPAM plugins loading in case of plugin getter is nil.
However, in Windows that is always the case so this logic needs to be revisitted.
Closes #50596
- How I did it
Removed plugin getter is nil check competely. However, it can be also done just for Windows in case it causes issues like this.
- How to verify it
Windows side tested like it is described in linked issue so if CI passes this should be fine.
- Human readable description for the release notes
- Fix a bug causing IPAM plugins to not be loaded on Windows