client: separate exec methods to ExecAPIClient interface#50997
Merged
thaJeztah merged 1 commit intomoby:masterfrom Sep 18, 2025
Merged
client: separate exec methods to ExecAPIClient interface#50997thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Sep 18, 2025
| ContainerExecInspect(ctx context.Context, execID string) (ExecInspect, error) | ||
| ContainerExecResize(ctx context.Context, execID string, options ContainerResizeOptions) error | ||
| ContainerExecStart(ctx context.Context, execID string, options ExecStartOptions) error | ||
| ExecAPIClient |
Member
Author
There was a problem hiding this comment.
FWIW, also considering removing this here to fully separate them, but I'd have to look at the impact for that, so this PR is just making preparations for some of that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)