daemon: Ensure buildkit created container's isolation mode is consistent with daemon's config in Windows#50942
Merged
vvoland merged 1 commit intomoby:masterfrom Nov 10, 2025
Conversation
vvoland
reviewed
Sep 9, 2025
vvoland
requested changes
Sep 9, 2025
Contributor
vvoland
left a comment
There was a problem hiding this comment.
LGTM, thanks! (but will leave a blocking review until the Buildkit changes are vendored)
61bc0b0 to
f08224d
Compare
f08224d to
6ebad69
Compare
Contributor
Author
|
Hi @vvoland, Buildkit changes in moby/buildkit#6224 has been vendored. The |
… with daemon's config - Introduced DefaultIsolation method in the Daemon to return the daemon configured isolation mode for Windows. Signed-off-by: Vigilans <vigilans@foxmail.com>
6ebad69 to
d192a63
Compare
Contributor
|
Rebased the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Currently, when enabling buildkit in Windows, the intermediate container created by buildlkit when building image will not follow docker daemon's configuration but stick to
processisolation. This will cause bug in machines that does not support process isolation, making them unable to build images with buildkit.This PR fixes this issue to ensure buildkit created container's isolation mode consistent with daemon's config.
- How I did it
SpecOptstoExecutorOption(Done in buildkit's repository: Support custom OCI spec options in containerd executor buildkit#6206, superseded by SupportHyperVIsolationoption in containerd executor in Windows buildkit#6224)DefaultIsolationfield of docker daemonWithWindowsHyperVspecOpts when daemon's default isolation mode ishyperv.- How to verify it
docker buildx build .- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)