api/types/checkpoint: move checkpoint options to client#50905
Merged
thaJeztah merged 1 commit intomoby:masterfrom Sep 5, 2025
Merged
api/types/checkpoint: move checkpoint options to client#50905thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Move the option-types to the client and in some cases create a copy for the backend. These types are used to construct query- args, and not marshaled to JSON, and can be replaced with functional options in the client. The CreateOptions type was used both as options-struct for the client, and as struct to marshal/unmarshal the request. For this type, a copy is created in the Client and a new `checkpoint.CreateRequest` is added in the API. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
ea40a1b to
a8afc2c
Compare
vvoland
approved these changes
Sep 5, 2025
This was referenced Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
api/typesdo not relate to the Engine API #50740Move the option-types to the client and in some cases create a copy for the backend. These types are used to construct query- args, and not marshaled to JSON, and can be replaced with functional options in the client.
The CreateOptions type was used both as options-struct for the client, and as struct to marshal/unmarshal the request. For this type, a copy is created in the Client and a new
checkpoint.CreateRequestis added in the API.- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)