[28.x] testutil/fixtures/plugin: makePluginBundle: fix invalid spec#50820
Merged
[28.x] testutil/fixtures/plugin: makePluginBundle: fix invalid spec#50820
Conversation
The fixture was using an invalid formatted Capability, which wasn't
detected in the old API code, but fails with the API module, for example:
=== RUN TestPluginsWithRuntimes
plugin_test.go:269: assertion failed: error is not nil: json: error calling MarshalText for type plugin.CapabilityID: capability "docker.dummy/1.0" cannot contain a dot
--- FAIL: TestPluginsWithRuntimes (0.63s)
=== RUN TestPluginBackCompatMediaTypes
plugin_test.go:331: assertion failed: error is not nil: json: error calling MarshalText for type plugin.CapabilityID: capability "docker.dummy/1.0" cannot contain a dot
--- FAIL: TestPluginBackCompatMediaTypes (0.11s)
FAIL
This patch applies the same changes as ee560a3
in the master branch.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
6 tasks
AkihiroSuda
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
The fixture was using an invalid formatted Capability, which wasn't detected in the old API code, but fails with the API module, for example:
This patch applies the same changes as ee560a3 in the master branch.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)