api/types/volume: move volume list options from api to client#50789
Merged
thaJeztah merged 4 commits intomoby:masterfrom Aug 22, 2025
Merged
Conversation
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
thaJeztah
reviewed
Aug 22, 2025
Member
There was a problem hiding this comment.
I think we may be able to generate this file now from the swagger spec. We can do that in a follow-up, but from the looks of it, I think we can.
thaJeztah
reviewed
Aug 22, 2025
| t.Helper() | ||
| client := testEnv.APIClient() | ||
| volumeList, err := client.VolumeList(ctx, volume.ListOptions{}) | ||
| apiClient := testEnv.APIClient() |
Member
There was a problem hiding this comment.
I made a few passes at this, but we should probably consider doing a rename for this across the board (i.e., integration, testutil, etc), and use apiClient as canonical name everywhere.
This was referenced Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Partial for #50740
This change moves the
volume.ListOptionstype from the api toVolumeListOptionstype in the client. This change also introduces a backendvolumebackend.ListOptionstype to keep the daemon decoupled from the client module.- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)