api/types/network: move network options from api to client#50786
Merged
thaJeztah merged 4 commits intomoby:masterfrom Aug 22, 2025
Merged
api/types/network: move network options from api to client#50786thaJeztah merged 4 commits intomoby:masterfrom
thaJeztah merged 4 commits intomoby:masterfrom
Conversation
68ac1ba to
72e491e
Compare
thaJeztah
requested changes
Aug 22, 2025
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM after squashing that commit 😅
Member
|
oh! also needs a rebase now 😅 |
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
72e491e to
fe8516c
Compare
Contributor
Author
|
@thaJeztah, I rebased and squashed the commit if you can take another look thanks! :) |
thaJeztah
approved these changes
Aug 22, 2025
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
sorry thought I did, but I had the tab still open 😂
72 tasks
This was referenced Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Partial of #50740
- How I did it
Moves the
network.ListOptionsandnetwork.InspectOptionstypes to the client mod- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)