api/types/registry: move auth config functions to pkg#50785
Merged
thaJeztah merged 2 commits intomoby:masterfrom Aug 26, 2025
Merged
api/types/registry: move auth config functions to pkg#50785thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah merged 2 commits intomoby:masterfrom
Conversation
8f3fb92 to
5b0471d
Compare
thaJeztah
reviewed
Aug 22, 2025
| "fmt" | ||
| "io" | ||
| ) | ||
| import "context" |
Member
There was a problem hiding this comment.
Looks like RequestAuthConfig below is only used in the client, and it's referred to through GoDoc in some places. We can probably move it as well, or even consider if it's adding value (other than documentation, which ... could probably be put in the places where the signature is used).
I haven't checked yet if it's referenced in other places though (e.g. the docker CLI or elsewhere)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
5b0471d to
bdce160
Compare
dmcgowan
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Partial for #50740
Alternative to #50765
- How I did it
Refactor the encode/decode auth config functions into their own utility package.
Carried forward the daemon touch-ups suggested from #50765
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)