[28.x] api/types: deprecate disk usage types for build cache, container, ima…#50768
Merged
austinvazquez merged 2 commits intomoby:28.xfrom Aug 19, 2025
Merged
Conversation
…ges, and volumes These types are only used internal to the daemon and will be removed from the api in the next release. Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
Member
|
Ah derp; we probably need some exclusion in the golangci-lint settings; Or maybe do the copying after all in this branch |
Contributor
Author
|
Oh, that's funny one of the few times I didn't run validate locally when creating the PR. |
…ge in daemon Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
Contributor
Author
|
@thaJeztah , I pushed a commit to silence the linters regarding deprecated type usage in the daemon if you can take another look. |
thaJeztah
approved these changes
Aug 19, 2025
Member
thaJeztah
left a comment
There was a problem hiding this comment.
works for me if the linter is happy
LGTM
Member
It's also not always consistent; I've had cases where I added a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ges, and volumes
- What I did
This change marks the disk usage structs in
api/types/build,api/types/container,api/types/images, andapi/types/volumesas deprecated.- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)