api/types/container: rename Port to PortSummary#50711
Merged
austinvazquez merged 1 commit intomoby:masterfrom Aug 13, 2025
Merged
api/types/container: rename Port to PortSummary#50711austinvazquez merged 1 commit intomoby:masterfrom
austinvazquez merged 1 commit intomoby:masterfrom
Conversation
thaJeztah
commented
Aug 13, 2025
| SandboxID string // SandboxID uniquely represents a container's network stack | ||
| SandboxKey string // SandboxKey identifies the sandbox | ||
| Ports PortMap // Ports is a collection of PortBinding indexed by Port | ||
| Ports PortMap // Ports is a collection of PortBinding indexed by "port/proto" see [PortProto] |
Member
Author
There was a problem hiding this comment.
Let me revert this as it's not directly related.
austinvazquez
approved these changes
Aug 13, 2025
vvoland
approved these changes
Aug 13, 2025
akerouanton
reviewed
Aug 13, 2025
api/docs/v1.52.yaml
Outdated
|
|
||
| definitions: | ||
| Port: | ||
| PortMapping: |
Member
There was a problem hiding this comment.
PortMapping sounds like a generic type that could be used to represent port mappings in many places. However, it's only used by ContainerSummary, and it's quite different from other types used for representing port bindings. So, maybe PortMappingSummary?
Member
Author
There was a problem hiding this comment.
@akerouanton perhaps PortSummary would that work? (as it's for the Port field) - slightly shorter.
3fe84b1 to
a776fcb
Compare
akerouanton
requested changes
Aug 13, 2025
vendor/github.com/moby/moby/api/types/container/port_mapping.go
Outdated
Show resolved
Hide resolved
It better describes its purpose, and allows "Port" to be used for other purposes (e.g. to replace "nat.Port"). Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Co-authored-by: Austin Vazquez <austin.vazquez@docker.com>
a776fcb to
82ba7fe
Compare
akerouanton
approved these changes
Aug 13, 2025
This was referenced Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PortSet,PortMap#50681It better describes its purpose, and allows "Port" to be used for other purposes (e.g. to replace "nat.Port").
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)