chore: enable use-any rule from revive#50672
Conversation
82833c8 to
c2a561b
Compare
|
Sorry, I've been slow to look at your other PRs because we've been busy on the modules work. Can you run |
|
Oh! and you missed one; |
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM after fixing those two issues - let's see if we can get this one in to get it out of the way ❤️
c2a561b to
17284c9
Compare
|
I will skip pkg/plugins/pluginrpc-gen/fixtures/foo.go for now as it requires an adaptation of the script to handle them. |
|
Yup, that makes sense as well. Same for the API package, because some of the generated files (which probably get ignored) also use |
No worries, I totally understand that
There are no changes for dependencies here |
|
Can you try running it? At least I get a diff locally; hack/vendor.sh
# ....
git status
On branch revive-use-any
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: vendor/github.com/moby/moby/client/hijack.go
modified: vendor/github.com/moby/moby/client/request.go |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
17284c9 to
96f8c63
Compare
- What I did
Use any instead of interface{}, enable use-any rule from revive alongside
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)