Stabilize TestSaveAndLoadPlatform integration test.#50650
Merged
thaJeztah merged 1 commit intomoby:masterfrom Aug 8, 2025
Merged
Stabilize TestSaveAndLoadPlatform integration test.#50650thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR stabilizes a flaky integration test by ensuring image load operations complete before proceeding with verification steps. The test was previously failing intermittently because it wasn't waiting for the asynchronous load operation to finish.
- Adds proper waiting for image load operations to complete by reading the response body
- Removes loaded images between test steps to ensure clean state
- Updates test comments for clarity
vvoland
approved these changes
Aug 7, 2025
thaJeztah
reviewed
Aug 7, 2025
Test was flaky because it was not waiting for an image load operation to complete before proceeding to check if the load succeeded. Fix this. Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
1a8c939 to
04d9500
Compare
austinvazquez
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Stabilize TestSaveAndLoadPlatform integration test.
Fixes #50531.
- How I did it
Test was flaky because it was not waiting for an image load operation to complete before proceeding to check if the load succeeded. Fix this.
- How to verify it
- A picture of a cute animal (not mandatory but encouraged)