[28.x] api/types/filters: reimplement ToParamWithVersion#50562
Merged
[28.x] api/types/filters: reimplement ToParamWithVersion#50562
Conversation
This function depended on the non-exported `Args.values` field. With the migration of the API to a separate module, we will alias that type, and remove the deprecated `ToParamWithVersion` function. This means that we cannot alias the function, and aliasing the `Args` type means we can't access the non-exported field. This patch reimplements `ToParamWithVersion` by unmarshaling the JSON output of the current format, and re-marshaling it to the legacy format. This is not optimal, but this code-path would only be used for API versions that are deprecated, and is not to be used for any new code. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
6 tasks
vvoland
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function depended on the non-exported
Args.valuesfield. With the migration of the API to a separate module, we will alias that type, and remove the deprecatedToParamWithVersionfunction.This means that we cannot alias the function, and aliasing the
Argstype means we can't access the non-exported field.This patch reimplements
ToParamWithVersionby unmarshaling the JSON output of the current format, and re-marshaling it to the legacy format.This is not optimal, but this code-path would only be used for API versions that are deprecated, and is not to be used for any new code.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)