pkg/system: move to daemon/internal#50559
Merged
thaJeztah merged 8 commits intomoby:masterfrom Jul 29, 2025
Merged
Conversation
It was deprecated in 63bada4, but won't be carried to the new modules. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
It was deprecated in f8a2550, but won't be carried to the new modules. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Remove the stub implementation for non-Windows platforms, and remove the os.FileMode argument, which is ignored on Windows. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
It's not used, and is not carried in the new module. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
It's only used in Linux code. Remove the stubs, which are not carried forward into the module. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
It's only produced in Linux code, so put it in a Linux-only file. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
It has no external users, and this package still has too many different responsibilities, some of which may be available elsewhere, so moving it internal so that we can decide to dismantle it further. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
vvoland
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/system: remove deprecated EscapeArgs
It was deprecated in 63bada4, but won't
be carried to the new modules.
pkg/system: remove deprecated IsAbs
It was deprecated in f8a2550, but won't
be carried to the new modules.
pkg/system: MkdirAllWithACL: remove stubs and unused os.FileMode arg
Remove the stub implementation for non-Windows platforms, and remove the
os.FileMode argument, which is ignored on Windows.
pkg/system: remove Lgetxattr, Lsetxattr stubs for non-Linux
It's only used in Linux code. Remove the stubs, which are not carried
forward into the module.
pkg/system: remove unused ErrNotSupportedPlatform
daemon/builder/remotecontext: remove detection of system.XattrError
Both locations checked an error from
filepath.Relin stdlib, whichwould never return a
system.XattrError, so this was just dead code.pkg/system: make XattrError linux-only
It's only produced in Linux code, so put it in a Linux-only file.
pkg/system: move to daemon/internal
It has no external users, and this package still has too many different
responsibilities, so moving it internal so that we can decide to dismantle
it further.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)