integration-cli: migrate TestPostContainersCreateShmSizeXXX to integration#50525
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jul 28, 2025
Merged
Conversation
…ation Some of these tests were making assumptions about the daemon's internals by using `config.DefaultShmSize` from the daemon config package. Rewrite them to start a daemon with a custom default, and verify the tests to use that default. This migrates the following tests from integration-cli to integration; - `DockerAPISuite.TestPostContainersCreateShmSizeNegative` - `DockerAPISuite.TestPostContainersCreateShmSizeHostConfigOmitted` - `DockerAPISuite.TestPostContainersCreateShmSizeOmitted` - `DockerAPISuite.TestPostContainersCreateWithShmSize` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
Interesting; https://github.com/moby/moby/actions/runs/16542857660/job/46786654831?pr=50525 |
vvoland
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of these tests were making assumptions about the daemon's internals by using
config.DefaultShmSizefrom the daemon config package.Rewrite them to start a daemon with a custom default, and verify the tests to use that default.
This migrates the following tests from integration-cli to integration;
DockerAPISuite.TestPostContainersCreateShmSizeNegativeDockerAPISuite.TestPostContainersCreateShmSizeHostConfigOmittedDockerAPISuite.TestPostContainersCreateShmSizeOmittedDockerAPISuite.TestPostContainersCreateWithShmSize- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)