integration-cli: migrated test TestContainerAPIRename to docker/cli#50507
Merged
thaJeztah merged 1 commit intomoby:masterfrom Aug 1, 2025
Merged
Conversation
vvoland
reviewed
Jul 24, 2025
Contributor
vvoland
left a comment
There was a problem hiding this comment.
Thanks! This looks to be roughly the same as TestRenameStoppedContainer.
It would probably make sense to rewrite it into a cli e2e test instead: https://github.com/docker/cli/tree/master/e2e/container
Contributor
Author
|
hi @vvoland, i created a PR in docker/cli here: docker/cli#6212. please take a look, thanks! |
Signed-off-by: carsontham <carsontham@outlook.com>
26c49f5 to
bbec7a5
Compare
Contributor
Author
|
hi @vvoland, I have submitted a PR to migrate TestContainerAPIRename to docker/cli instead. The PR docker/cli#6212 has been merged. For this PR, it is just to remove the TestContainerAPIRename. Could you have a look? thanks! |
thaJeztah
approved these changes
Aug 1, 2025
Member
thaJeztah
left a comment
There was a problem hiding this comment.
Ah, yes, this one only has to do the remove now!
LGTM, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Migrated the TestContainerAPIRename to docker/cli. This PR will remove the already migrated test for TestContainerAPIRename.
Issue reference: #50159
Merged PR reference: docker/cli#6212
- How I did it
Migrated TestContainerAPIRename to docker/cli.
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)
🐳