Skip to content

hack/buildkit-ref: temporarily bump BuildKit to head of v0.23 branch#50451

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:gha_bump_bk
Jul 20, 2025
Merged

hack/buildkit-ref: temporarily bump BuildKit to head of v0.23 branch#50451
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:gha_bump_bk

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jul 20, 2025

To skip some flaky tests on Windows

diff: moby/buildkit@v0.23.2...dd2b4e1

- Human readable description for the release notes



- A picture of a cute animal (not mandatory but encouraged)

    

  
  



      


          

          
  
  

    
  
    
    

  

  

  



                    

          
        





  





    



      

  
            

    

      
    

    


      


          @thaJeztah
thaJeztah




          added this to the 
  29.0.0 milestone


      Jul 20, 2025

    

  



    







      

  
      



  

  @thaJeztah






  



    

      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

        
      

    


    

        

  
  Member


        

  Author


    

  


  

    

      
          
      

      
            thaJeztah
  

      

      

      commented


        Jul 20, 2025


      
    


  





      


        



  
    

      
          
Ugh; does this no longer work? ISTR this is what we did previously 🤔


Fetching the repository
  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --depth=1 origin dd2b4e18663c58ac3762d7b60b2c3301f71d5fa9
  Error: fatal: remote error: upload-pack: not our ref dd2b4e18663c58ac3762d7b60b2c3301f71d5fa9
  The process '/usr/bin/git' failed with exit code 128
  Waiting 13 seconds before trying again
  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --depth=1 origin dd2b4e18663c58ac3762d7b60b2c3301f71d5fa9
  Error: fatal: remote error: upload-pack: not our ref dd2b4e18663c58ac3762d7b60b2c3301f71d5fa9
  The process '/usr/bin/git' failed with exit code 128
  Waiting 11 seconds before trying again
  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --depth=1 origin dd2b4e18663c58ac3762d7b60b2c3301f71d5fa9
  Error: fatal: remote error: upload-pack: not our ref dd2b4e18663c58ac3762d7b60b2c3301f71d5fa9
  Error: The process '/usr/bin/git' failed with exit code 128



      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @thaJeztah






  



    

      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

        
      

    


    

        

  
  Member


        

  Author


    

  


  

    

      
          
      

      
            thaJeztah
  

      

      

      commented


        Jul 20, 2025


      
    


  





      


        



  
    

      
          
Oh! It now also sets the repo; 

  

    

      moby/hack/buildkit-ref
    

    

        Lines 22 to 25
      in
      f776cd6
    

  

  

    


        

          
           cat << EOF 
        


        

          
           BUILDKIT_REPO=$buildkit_repo 
        


        

          
           BUILDKIT_REF=$buildkit_ref 
        


        

          
           EOF 
        

    

  






      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
          
  

  
  

  
      @thaJeztah
  thaJeztah


          requested a review
  from tianon
    as a code owner


    July 20, 2025 13:05    
    









      

  
        

  

      

  
  

  
          

  

    

      


  

      
        @thaJeztah
  




      

        
          hack/buildkit-ref: temporarily bump BuildKit to head of v0.23 branch
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          1cc4264
        
      

    

  

    

      
To skip some flaky tests on Windows

diff: moby/buildkit@v0.23.2...dd2b4e1

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

    







  








      

  
          
    

    

      
    

    


      


          @thaJeztah
thaJeztah




        changed the title
gha: temporarily bump BuildKit to head of v0.23 branch

hack/buildkit-ref: temporarily bump BuildKit to head of v0.23 branch


      Jul 20, 2025

    

  








      

  
        





      

  
      



  

  @thaJeztah






  



    

      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

        
      

    


    

        

  
  Member


        

  Author


    

  


  

    

      
          
      

      
            thaJeztah
  

      

      

      commented


        Jul 20, 2025


      
    


  





      


        



  
    

      
          
Thx! Let me bring this one in


      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
          
 
  

    
  

  


        
        @thaJeztah
  thaJeztah



        merged commit b10cbd9
      into

      
  
    moby:master
  


    Jul 20, 2025

      

        177 checks passed
      


      

        
  
          
  
    
    


  
      

  







  

  
  

  
      @thaJeztah
  thaJeztah


    
    deleted the
    
      
        gha_bump_bk
    
    branch

    July 20, 2025 20:15    
    




  

  

    
  


  

      


    @thaJeztah
thaJeztah



    mentioned this pull request
    
      Jul 22, 2025
    





  


  

      
   Merged

  







  









      

  
      



  

  @vvoland






  



    

      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

        
      

    


    

        

  
    Contributor


        

    

  


  

    

      
          
      

      
            vvoland
  

      

      

      commented


        Aug 11, 2025


      
    


  





      


        



  
    

      
          
We'll be backporting the new buildkit version so let's skip this one from 28.x


      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
            











  
  

    

      

  










  








  
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  










      

  

    
    

    

  

    Reviewers
  


    


      
  

    


  
      @crazy-max
  
    crazy-max



    
      
        
      
    
    crazy-max approved these changes

  


      

          


  
      @tianon
  
    tianon


                Awaiting requested review from tianon

                    tianon is a code owner

        
      


      






    
    
    

    

  


      
  

    Assignees
  



        


    No one assigned







      


  


  

    Labels
  



    

      

    area/builder/buildkit

  Build
  

    area/testing

  

    status/2-code-review









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      
    
  
    29.0.0
  





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.





  
  



      
    

  




      

    

  
      

  

    

      3 participants
    

    

        
          @thaJeztah 
        
          @vvoland 
        
          @crazy-max