api/types/registry: EncodeAuthConfig: use empty string for zero value#50426
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jul 17, 2025
Merged
api/types/registry: EncodeAuthConfig: use empty string for zero value#50426thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Currently, EncodeAuthConfig always returns a base64url-encoded JSON doc, even if an empty auth-config passed. As a result, it's more complicated to detect if authentication was present. This patch changes the behavior to return an empty string for these cases so that teh client can skip setting the `X-Registry-Auth` header, and the daemon can detect whether authentication is sent or not. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
austinvazquez
approved these changes
Jul 16, 2025
This was referenced Aug 4, 2025
This was referenced Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to;
Currently, EncodeAuthConfig always returns a base64url-encoded JSON doc, even if an empty auth-config passed. As a result, it's more complicated to detect if authentication was present.
This patch changes the behavior to return an empty string for these cases so that teh client can skip setting the
X-Registry-Authheader, and the daemon can detect whether authentication is sent or not.- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)