registry: remove deprecated HostCertsDir() and SetCertsDir()#50373
Merged
thaJeztah merged 2 commits intomoby:masterfrom Jul 11, 2025
Merged
registry: remove deprecated HostCertsDir() and SetCertsDir()#50373thaJeztah merged 2 commits intomoby:masterfrom
HostCertsDir() and SetCertsDir()#50373thaJeztah merged 2 commits intomoby:masterfrom
Conversation
This was deprecated in dd7ab0e which was in v28, and no longer has any consumer, so we can remove it. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was deprecated in b633c4c, which was in v28, and no longer has any consumer, so we can remove it. Now that we no longer have to synchronise `CertsDir` with `SetCertsDir` we can also remove the synchronization (`homedir.GetConfigHome()` does some additional lookups, but those usually are just looking up env-vars, and `user.Current()` already has a `sync.Once` or equivalent). Also unifying the platform-specific code to remove some abstraction and put the logic in plain sight. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
547f98d to
5862b92
Compare
robmry
approved these changes
Jul 11, 2025
dmcgowan
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
registry: remove deprecated HostCertsDir
This was deprecated in dd7ab0e which was
in v28, and no longer has any consumer, so we can remove it.
registry: remove deprecated SetCertsDir and unify CertsDir code
This was deprecated in b633c4c, which was
in v28, and no longer has any consumer, so we can remove it.
Now that we no longer have to synchronise
CertsDirwithSetCertsDirwe can also remove the synchronization (
homedir.GetConfigHome()doessome additional lookups, but those usually are just looking up env-vars,
and
user.Current()already has async.Onceor equivalent). Alsounifying the platform-specific code to remove some abstraction and put
the logic in plain sight.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)