Skip to content

Move volume under daemon#50367

Merged
austinvazquez merged 5 commits intomoby:masterfrom
dmcgowan:move-volume-daemon
Jul 17, 2025
Merged

Move volume under daemon#50367
austinvazquez merged 5 commits intomoby:masterfrom
dmcgowan:move-volume-daemon

Conversation

@dmcgowan
Copy link
Member

Moves volume and associated packages under daemon

Note the safepath went from internal to under volume since it is used by an integration test. It could go back to internal in the future if we copy the string output to the test.

@thaJeztah
Copy link
Member

We probably need to split things up here; part of the volume/ package is related to the volume "service" used by the daemon, but part is a public API, which at least is used for the volume-plugins (we still need to move that repository to the moby org); https://github.com/docker/go-plugins-helpers/blob/45e2431495c83b9ca1c2a669987d6e1afad07774/volume/shim/shim.go#L4

@thaJeztah
Copy link
Member

Looks like the volume/mounts package also has at least 1 external consumer; I somewhat doubt they're using the correct thing there, but we need to check if we have alternatives for what they're doing; I know some of the parsing has been non-trivial, so we should check if we have proper utilities for those (somewhere in the client or elsewhere) https://github.com/buildpacks/pack/blob/fb0563f4cdb51ae32463088fccefe5c961bbdd07/pkg/client/process_volumes.go#L10-L16

@dmcgowan
Copy link
Member Author

Looks like the volume/mounts package also has at least 1 external consumer;

This is not going to internal, importers can use the new package location, it will also not be considered stable. They can continue to use the 28 tag in the existing location. After we move this, we can decide of moving any package that is used externally to a more stable location, that would either be under github.com/moby/moby/api, github.com/moby/moby/client or other repo moby repo not under github.com/moby/moby.

We can get this one before we make those decisions, we can track those cases somewhere if that is easier.

@dmcgowan dmcgowan added this to the 29.0.0 milestone Jul 14, 2025
@dmcgowan dmcgowan force-pushed the move-volume-daemon branch from 9e9cd73 to cbb2ecb Compare July 14, 2025 18:47
@dmcgowan dmcgowan moved this to In Progress in go modules transition Jul 15, 2025
dmcgowan added 5 commits July 15, 2025 10:44
Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
@dmcgowan dmcgowan force-pushed the move-volume-daemon branch from cbb2ecb to 17d5f73 Compare July 15, 2025 17:52
@thompson-shaun thompson-shaun requested review from thaJeztah and vvoland and removed request for thaJeztah July 16, 2025 13:02
@dmcgowan dmcgowan added the release-blocker PRs we want to block a release on label Jul 16, 2025
Copy link
Contributor

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, windows test failures should be fixed in mainline not worth the rebase though IMO.

@austinvazquez austinvazquez merged commit f776cd6 into moby:master Jul 17, 2025
184 of 188 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in go modules transition Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/daemon Core Engine area/volumes Volumes go-modules kind/refactor PR's that refactor, or clean-up code release-blocker PRs we want to block a release on status/2-code-review

Projects

Development

Successfully merging this pull request may close these issues.

5 participants