Move builder under daemon#50365
Conversation
| "github.com/docker/docker/builder" | ||
| "github.com/docker/docker/builder/remotecontext" | ||
| "github.com/docker/docker/daemon/builder" | ||
| "github.com/docker/docker/daemon/builder/remotecontext" |
There was a problem hiding this comment.
We can't move the remotecontext package in the daemon; parts of it are used by the CLI, compose, and buildx. Not sure what the best place for it though; we used to have a pkg/urlutil but it was (very wrongfully) used externally for wrong purposes, which is why we moved it to be in the builder package (and added some warnings); see
- pkg/urlutil: deprecate, and move to builder/remotecontext/urlutil #43477
- remove aliases for deprecated pkg/urlutil, pkg/fsutils, pkg/pubsub #44261
But it's possible that we need to split some of the functionality, as some is used internally, some by the CLI, other bits elsewhere.
There was a problem hiding this comment.
What do you propose here? It is not internal and there is nothing stopping us from splitting it out completely.
There was a problem hiding this comment.
Opened #50372 to track usage of non-client/non-api packages
There was a problem hiding this comment.
d82d7d8 to
f601a5a
Compare
| mobyexporter "github.com/docker/docker/builder/builder-next/exporter" | ||
| imageadapter "github.com/docker/docker/daemon/internal/builder-next/adapters/containerimage" | ||
| mobyexporter "github.com/docker/docker/daemon/internal/builder-next/exporter" | ||
| "github.com/docker/docker/daemon/internal/mod" |
There was a problem hiding this comment.
FWIW; mod is only used in builder-next/worker; we could consider moving it internal to that;
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM if docker/cli#6190 is accepted.
Left one comment for the mod package; not really blocking, but perhaps good to have it all done.
I also had a minor PR following some linting issues that I got on the CLI (we should enable those linters here as well probably); in case you need to update this PR; #50423
f601a5a to
f012d4e
Compare
Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
f012d4e to
b83f368
Compare
austinvazquez
left a comment
There was a problem hiding this comment.
LGTM and docker/cli#6190 is trending positive. Pulling this in to unblock some other PRs. Can always follow-up if needed. Thanks.
Move builder under daemon. Also moves
builder-nextinto internal and thedaemon/buildpackage (previously for api backend) todaemon/builder/backend