Add read timeout support for fluentd logger#50249
Merged
thaJeztah merged 4 commits intomoby:masterfrom Aug 28, 2025
Merged
Conversation
efda038 to
ee7c7cc
Compare
thaJeztah
reviewed
Jun 25, 2025
vendor.mod
Outdated
Comment on lines
+196
to
+197
| github.com/philhofer/fwd v1.1.2 // indirect | ||
| github.com/philhofer/fwd v1.1.3-0.20240916144458-20a13a1f6b7c // indirect |
Member
There was a problem hiding this comment.
- FWIW, I requested the author of this module to tag a new release; new tagged (v1.2.0) release philhofer/fwd#35
thaJeztah
reviewed
Jun 25, 2025
thaJeztah
reviewed
Jun 25, 2025
This was referenced Jun 25, 2025
ee7c7cc to
7a147ae
Compare
Member
|
Did a quick rebase, and split the dependency updates, also updated to the tagged version of |
7a147ae to
bb02fa6
Compare
full diff: philhofer/fwd@v1.1.2...v1.2.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: tinylib/msgp@v1.1.8...v1.3.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: fluent/fluent-logger-golang@v1.9.0...v1.10.1 Update fluent-logger-golang to its latest release. This brings in a number of changes including the ability to configure a read timeout and some thread safety improvements. Signed-off-by: Anirudh Aithal <aithal@amazon.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Adds a new configuration to specify a read timeout for acks. Fluentd can be configured to expect acks from the server. In such scenarios, this configuration enables clients to timeout the read operation if the server or the connection is unresponsive. The default behavior of waiting forever remains unchanged. Signed-off-by: Anirudh Aithal <aithal@amazon.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
bb02fa6 to
dbe19a5
Compare
Member
|
Rebased and updated the dependency to v1.10.1, which downgraded the go version to go1.23.0; #50249 (comment) |
austinvazquez
approved these changes
Aug 28, 2025
Contributor
austinvazquez
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work on the tests and patience sorting through the fluentd go sdk stuff.
thaJeztah
approved these changes
Aug 28, 2025
Member
thaJeztah
left a comment
There was a problem hiding this comment.
"LGTM" (but I pushed the last update 😅)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vendor: github.com/philhofer/fwd v1.2.0
full diff: philhofer/fwd@v1.1.2...v1.2.0
vendor: github.com/tinylib/msgp v1.3.0
full diff: tinylib/msgp@v1.1.8...v1.3.0
vendor: github.com/fluent/fluent-logger-golang v1.10.1
full diff: fluent/fluent-logger-golang@v1.9.0...v1.10.1
Update fluent-logger-golang to its latest release. This brings in a
number of changes including the ability to configure a read timeout
and some thread safety improvements.
- What I did
Similar to #49911, these changes add a new configuration option (
fluentd-read-timeout), which lets clients specify a read timeout for reading acks from server.- How I did it
- How to verify it
- Human readable description for the release notes