Fix flaky test TestDaemonRestartRestoreBridgeNetwork#50196
Merged
robmry merged 1 commit intomoby:masterfrom Jun 13, 2025
Merged
Fix flaky test TestDaemonRestartRestoreBridgeNetwork#50196robmry merged 1 commit intomoby:masterfrom
robmry merged 1 commit intomoby:masterfrom
Conversation
It checked for "Bind for 0.0.0.0:80 failed: port is already allocated". But, since commit d662091 ("portallocator: always check for ports allocated for 0.0.0.0/::"), the message is sometimes about ":::80". Signed-off-by: Rob Murray <rob.murray@docker.com>
Member
🙈 😂 - at least happy we have a clear reason |
vvoland
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
The test checked for "Bind for 0.0.0.0:80 failed: port is already allocated".
But, since commit d662091 ("portallocator: always check for ports allocated for 0.0.0.0/::"), the message is sometimes about ":::80".
- How I did it
Just check for "port is already allocated".
- How to verify it
- Human readable description for the release notes