Conversation
thaJeztah
left a comment
There was a problem hiding this comment.
Some minor nits, but LGTM otherwise
| type: "string" | ||
| example: "nftables" |
There was a problem hiding this comment.
Not a real blocker, but we could add an enum to this to indicate values it can return; I guess nftables is not yet possible with this PR, correct?
| type: "string" | |
| example: "nftables" | |
| type: "string" | |
| enum: ["iptables", "iptables+firewalld"] | |
| example: "iptables" |
There was a problem hiding this comment.
This change has a life of its own, but it was only intended to be something we can see in docker info in bug reports (once added to the CLI), and check in our integration tests because the firewalld tests were running without firewalld enabled for some months.
I think it's best not to try to lock it down or treat new values as API changes, or it'll just get out of step or force us into otherwise-unnecessary API version bumps?
You suggested aligning earlier incarnations of the change with reporting of storage drivers - can we stick with that?
Lines 6451 to 6454 in ecb03c4
There was a problem hiding this comment.
(And, right - no nftables yet. But, soon, it should become the common case.)
There was a problem hiding this comment.
Yeah, makes sense. Mostly was wondering if it would help describing what to expect (not 100% sure if we must consider adding new options to the enum to require an API version bump, but good call)
api/swagger.yaml
Outdated
| items: | ||
| type: "string" | ||
| example: | ||
| - ["ReloadedAt", "2025-01-01 00:00:00"] |
There was a problem hiding this comment.
Per the other PR; if we decide to use RFC3339 (or ..Nano), we could update the example to match that format;
| - ["ReloadedAt", "2025-01-01 00:00:00"] | |
| - ["ReloadedAt", "2025-01-01T00:00:00Z"] |
| - ["ReloadedAt", "2025-01-01 00:00:00"] | |
| - ["ReloadedAt", "2025-01-01T00:00:00.000000001Z"] |
The Z depends on whether we'll use UTC, otherwise it may show something like +02:00 or Z (depending on the hosts's config)
3c6045a to
b2eea03
Compare
b2eea03 to
effcffd
Compare
|
A, derp; needs a rebase for the |
effcffd to
1c1fae4
Compare
Report FirewallBackend in "docker info". It's currently "iptables" or "iptables+firewalld" on Linux, and omitted on Windows. Signed-off-by: Rob Murray <rob.murray@docker.com>
1c1fae4 to
a0a86d0
Compare
- What I did
Report FirewallBackend in "docker info".
It's currently "iptables" or "iptables+firewalld" on Linux, and omitted on Windows.
- How I did it
- How to verify it
New integration test.
- Human readable description for the release notes