registry: deprecate APIEndpoint.Official field#49706
Merged
thaJeztah merged 1 commit intomoby:masterfrom Mar 28, 2025
Merged
Conversation
This field was introduced in 19515a7 when the registry code was replaced for code vendored from docker/distribution. It was used for v1 registries to update the "TrustStore" for signed manifests; https://github.com/moby/moby/blob/19515a7ad859b28c474d81e756ac245afcd968e3/graph/pull.go#L89-L93 Before that, it used the IndexInfo.Official field; https://github.com/moby/moby/blob/276c640be4b4335e3b8d684cb3562a56d3337b39/graph/pull.go#L94-L97 And related to "v2" registries; moby@88fdcfe Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
neersighted
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This field was introduced in 19515a7 when the registry code was replaced for code vendored from docker/distribution.
It was used for v1 registries to update the "TrustStore" for signed manifests;
moby/graph/pull.go
Lines 89 to 93 in 19515a7
Before that, it used the IndexInfo.Official field;
moby/graph/pull.go
Lines 94 to 97 in 276c640
And related to "v2" registries;
88fdcfe
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)