containerd: prioritize non-dangling images with image list#49672
containerd: prioritize non-dangling images with image list#49672robmry merged 1 commit intomoby:masterfrom
Conversation
When listing images, prioritize the tagged version. When computing the unique images, the last returned image would be used as a base and repo tags would be merged into it. This makes it so `RepoDigests` has the correct value when there is both a dangling and non-dangling version of the same image. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
|
This LGTM - but should it have a regression test? |
|
@robmry it might be difficult to create a regression test for this unless something like #49669 being merged since the current daemon doesn't create the dangling image on creation at the moment. I think this would end up being covered by some existing tests if we change the default behavior for creating dangling images since test failures on the above PR is the reason I found this to begin with. |
Got it - thank you! |
When listing images, prioritize the tagged version. When computing the
unique images, the last returned image would be used as a base and repo
tags would be merged into it.
This makes it so
RepoDigestshas the correct value when there is botha dangling and non-dangling version of the same image.