Skip to content

ci(bin-image): use distribute reusable workflow#49474

Open
crazy-max wants to merge 1 commit intomoby:masterfrom
crazy-max:ci-bin-image-distribute
Open

ci(bin-image): use distribute reusable workflow#49474
crazy-max wants to merge 1 commit intomoby:masterfrom
crazy-max:ci-bin-image-distribute

Conversation

@crazy-max
Copy link
Copy Markdown
Member

@crazy-max crazy-max commented Feb 17, 2025

Switch to reusable workflow distributing multi-platform build across runners for bin-image job: https://github.com/crazy-max/.github?tab=readme-ov-file#bake-distribute-mp

@crazy-max crazy-max force-pushed the ci-bin-image-distribute branch from c0526a4 to 5e8fe9b Compare February 17, 2025 13:26
@crazy-max crazy-max force-pushed the ci-bin-image-distribute branch from 5e8fe9b to 7f2a28c Compare March 5, 2025 11:34
@crazy-max crazy-max force-pushed the ci-bin-image-distribute branch from 7f2a28c to 6f295f0 Compare March 5, 2025 11:39
@crazy-max crazy-max force-pushed the ci-bin-image-distribute branch from 6f295f0 to 57afdd4 Compare April 8, 2025 09:53
@crazy-max crazy-max changed the title [DNM] ci(bin-image): use upstream distribute reusable workflow ci(bin-image): use distribute reusable workflow Apr 8, 2025
@crazy-max crazy-max requested review from thaJeztah and vvoland April 8, 2025 09:55
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max force-pushed the ci-bin-image-distribute branch from 57afdd4 to f936d48 Compare April 8, 2025 10:37
@crazy-max crazy-max marked this pull request as ready for review April 8, 2025 10:40
build:
runs-on: ubuntu-24.04
timeout-minutes: 120 # guardrails timeout for the whole job
uses: crazy-max/.github/.github/workflows/bake-distribute-mp.yml@8a89518a596466dc5ebfee758d1456398f29b036
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This something we should ultimately have inside the moby org? Or is it really generic, and not really for just moby?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is generic, see for example the one in buildx repo: https://github.com/docker/buildx/pull/3005/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721R416

We aim to put this kind of reusable workflow in bake-action repo in the future docker/bake-action#302 but we want to achieve image signing with OIDC before that.

@crazy-max
Copy link
Copy Markdown
Member Author

crazy-max commented Apr 24, 2025

Related to this issue docker/actions-toolkit#677 (comment) I put this one in draft until git context is fixed. We could also switch to path context in the reusable workflow in the meantime similar to docker/buildx#3155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants