vendor: test moby dockerd integration tests with custom docker client#49459
Closed
jsternberg wants to merge 1 commit intomoby:masterfrom
Closed
vendor: test moby dockerd integration tests with custom docker client#49459jsternberg wants to merge 1 commit intomoby:masterfrom
jsternberg wants to merge 1 commit intomoby:masterfrom
Conversation
00e3925 to
11a008b
Compare
3e092ec to
04354bc
Compare
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
04354bc to
2270db8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Moved a slim version of the docker api client to buildkit for its integration tests.
moby/buildkit#5731
- How I did it
Copied over the client from moby and then deleted sections until it used the subset needed by buildkit's integration tests.
- How to verify it
The tests should pass in this draft PR.
- A picture of a cute animal (not mandatory but encouraged)