Skip to content

client: remove uses of pkg/errors in tests#49356

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:client_reduce_test_deps
Jan 29, 2025
Merged

client: remove uses of pkg/errors in tests#49356
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:client_reduce_test_deps

Conversation

@thaJeztah
Copy link
Member

While there may be reasons to keep pkg/errors in production code, we don't need them for these tests.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

While there may be reasons to keep pkg/errors in production
code, we don't need them for these tests.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added area/api API status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Jan 29, 2025
@thaJeztah thaJeztah self-assigned this Jan 29, 2025
@thaJeztah
Copy link
Member Author

Flaky test (tracked in #49358)

=== Failed
=== FAIL: arm64.integration.networking TestAccessPublishedPortFromAnotherNetwork/IPv6/Host (0.64s)
    port_mapping_linux_test.go:877: assertion failed: string "" does not contain "foobar": Payload was not received by the server container
    --- FAIL: TestAccessPublishedPortFromAnotherNetwork/IPv6/Host (0.64s)

=== FAIL: arm64.integration.networking TestAccessPublishedPortFromAnotherNetwork (3.03s)

@thaJeztah thaJeztah merged commit c42005e into moby:master Jan 29, 2025
159 checks passed
@thaJeztah thaJeztah deleted the client_reduce_test_deps branch January 29, 2025 22:26
@thaJeztah thaJeztah added this to the 28.0.0 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api API kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants