[27.x] update go:build tags to use go1.22, fix missing go:build tags#48885
Merged
[27.x] update go:build tags to use go1.22, fix missing go:build tags#48885
Conversation
…g to go1.16 commit 2847c4b switched networkdb to use go-immutable-radix v2, which uses generics, but failed to add the go:build directives. # github.com/docker/docker/libnetwork/networkdb ../../libnetwork/networkdb/networkdb.go:47:19: type instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod) ../../libnetwork/networkdb/networkdb.go:259:33: type instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod) ../../libnetwork/networkdb/networkdb.go:269:25: function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod) ../../libnetwork/networkdb/networkdb.go:270:27: function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 5403e3f) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
…rading to go1.16 commit 77f2d90 introduced the slices import, which uses generics, but failed to add the go:build directives. # github.com/docker/docker/daemon/logger/loggerutils ../../daemon/logger/loggerutils/logfile.go:770:2: implicit function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit fb6da4f) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
commit a0807e7 configured golangci-lint to use go1.23 semantics, which alowed linters like `copyloopvar` to lint using thee correct semantics. go1.22 now creates a copy of variables when assigned in a loop; make sure we don't have files that may downgrade semantics to go1.21 in case that also means disabling that feature; https://go.dev/ref/spec#Go_1.22 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit b453aa6) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was introduced in c902e1a; make BIND_DIR=. shell make -C ./internal/gocompat/ GO111MODULE=on go test -v # github.com/docker/docker/daemon/containerd ../../daemon/containerd/image.go:113:17: implicit function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod) ../../daemon/containerd/image.go:113:32: "github.com/distribution/reference".Named to satisfy comparable requires go1.20 or later (-lang was set to go1.16; check go.mod) ../../daemon/containerd/image_list.go:505:16: implicit function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
Failure is unrelated; |
vvoland
approved these changes
Nov 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(partial) backports:
[27.x] daemon/containerd: add missing go:build tag
relates to:
This was introduced in c902e1a;