Increase flaky test sleep, replace deprecated assert#48417
Increase flaky test sleep, replace deprecated assert#48417vvoland merged 1 commit intomoby:masterfrom
Conversation
- increase mock handler processing time to 50ms to try to prevent it from finishing before the 10ms client timeout occurs - replace deprecated error type assertion Signed-off-by: Adam Simon <adamsimon85100@gmail.com>
vvoland
left a comment
There was a problem hiding this comment.
Thanks for picking this up!
For verifying whether the test is still flaky - you could add a new temporary commit that would modify the code so that the test code is ran like x100 times:
func TestNewClientWithTimeout(t *testing.T) {
t.Parallel()
for i := 0; i < 100; i++ {
t.Run(strconv.Itoa(i), func(...) {
<test body...>
}
}
}|
Modified it to run the test 100 times. Before I also ran it with go test -count 100 multiple times to see if it fails, it seemed fine. |
|
Closing and reopening to re-run the CI. |
vvoland
left a comment
There was a problem hiding this comment.
LGTM (after removing the last commit 😄)
|
Reverted the last commit, I hope the test won't fail anymore. I don't really know why it was failing in the first place, maybe the timeouts aren't that accurate and some additional waiting happens somewhere when the system is under load? |
|
The changed test passed, but some networkdb test (TestNetworkDBIslands) failed :( |
|
The networkdb test is a known flaky, don't worry about it. As for removing the commit - instead of reverting it with another commit, you can just remove it so the PR has only the first commit. You can do that with |
2816ec1 to
28dc2f6
Compare
|
Done (I thought the commits would be squashed on merge). |
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)