c8d/list: Don't exclude non-container images#48399
Merged
vvoland merged 1 commit intomoby:masterfrom Aug 29, 2024
Merged
Conversation
Before this, the image list would not show images that are not a valid container image, but could be a valid artifact. While they're not directly usable by docker, we should still show them so the user can still discover them and at least be able to delete them. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
tianon
reviewed
Aug 29, 2024
Comment on lines
-390
to
-393
| // TODO we should probably show *something* for images we've pulled | ||
| // but are 100% shallow or an empty manifest list/index | ||
| // ("tianon/scratch:index" is an empty example image index and | ||
| // "tianon/scratch:list" is an empty example manifest list) |
Member
There was a problem hiding this comment.
At least I'm 100% consistently on-brand, right? 😄
tianon
approved these changes
Aug 29, 2024
Member
tianon
left a comment
There was a problem hiding this comment.
This seems really sane to me, especially in the containerd integration -- these are valid OCI objects, so being able to successfully pull them and list them, even though they'll fail to run, seems like sane behavior IMO, especially if we someday do something interesting with #44369. 👀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this, the image list would not show images that are not a valid container image, but could be a valid artifact.
While they're not directly usable by docker, we should still show them so the user can still discover them and at least be able to delete them.
- What I did
- How I did it
- How to verify it
TestImageList
and
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)