feat(stream): log the event when stream copy failed#48334
Merged
thaJeztah merged 1 commit intomoby:masterfrom Aug 19, 2024
Merged
feat(stream): log the event when stream copy failed#48334thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Contributor
Author
|
@cpuguy83 hello~ can you take a look here and take a review? |
thaJeztah
reviewed
Aug 15, 2024
Member
thaJeztah
left a comment
There was a problem hiding this comment.
Thanks!
At a quick glance, this seems fine to me; I left some suggestions, and can wait for others to have a look in case I overlooked any reason not to log these.
(FWIW; some maintainers are currently on vacation, so some delay may happen w.r.t. reviews / feedback)
Contributor
Author
|
Yes, you are right. I just adjust the log to make likes other log output in the project. |
thaJeztah
reviewed
Aug 16, 2024
Signed-off-by: 7sunarni <710720732@qq.com>
Contributor
Author
|
Fine. I adjusted the error message. |
vvoland
approved these changes
Aug 19, 2024
thaJeztah
approved these changes
Aug 19, 2024
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
sorry for the delay, thought I already submitted 🙈
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I met
I met a problem when I ran KinD failed in my machine, and I found that KinD can not write it's config to docker container from KinD log.
After I checked the KinD code, I realized that when ran
echo "hello" | docker exec -i $CONTAINER cat /dev/stdinwill not get any output in my machine (works well in other machine). So, there must be a problem in somewhere.Then I spent lots of time on docker cli, docker daemon, containerd, containerd-shim to find where the input or output data lost, because there is not failed log.
I hope this commit will help people save their time if they have same problem.
- What I did
add failed log when copy from stdin to iop pipe stdin
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)