gha: check-pr-branch: verify major version only #48177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The error message is a bit wrong now (it fails correctly though). |
vvoland
reviewed
Jul 18, 2024
d2a8d19 to
021dc63
Compare
Member
Author
|
@vvoland updated; PTAL (I also updated the backport) |
corhere
reviewed
Jul 18, 2024
vvoland
approved these changes
Jul 18, 2024
corhere
reviewed
Jul 18, 2024
cb31146 to
0a14eb3
Compare
corhere
approved these changes
Jul 18, 2024
Member
Author
|
Ah, dang; YAML! |
We'll be using release branches for minor version updates, so instead of (e.g.) a 27.0 branch, we'll be using 27.x and continue using the branch for minor version updates. This patch changes the validation step to only compare against the major version. Co-authored-by: Cory Snider <corhere@gmail.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
0a14eb3 to
f460110
Compare
This was referenced Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll be using release branches for minor version updates, so instead of (e.g.) a 27.0 branch, we'll be using 27.x and continue using the branch for minor version updates.
This patch changes the validation step to only compare against the major version.
- A picture of a cute animal (not mandatory but encouraged)